-
Notifications
You must be signed in to change notification settings - Fork 18
feat(sony): add Bravia REST API driver #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KesterJJ
wants to merge
4
commits into
master
Choose a base branch
from
feat/sony/bravia-rest-api-driver
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive Sony Bravia display driver supporting REST API control with: - Power management (on/off/standby with status polling) - Volume control (set, mute/unmute, volume up/down with state polling) - Input switching (HDMI1-4, Component, Composite, etc. with current input polling) - Extended functionality (apps, picture settings, IR codes, system info) - Thread-safe API calls with mutex protection - Robust error handling and PSK authentication validation - Full interface compliance (Powerable, Muteable, Switchable) - Comprehensive test suite with edge case coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Very cool, does it compile and pass the spec? Using driver test harness |
|
Also I'm curious what was the prompt, can you paste it here? |
stakach
requested changes
Jun 12, 2025
|
I updated it by fixing the spec runner on the AI repo |
stakach
previously approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive Sony Bravia display driver supporting REST API control with: